You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Offer every special button action, including Battery level - #9
Action::choices (src/mouse.rs:74) used 1..SPECIALS.len() - 1, which skips the last entry. So "Battery level" was never offered for a button that supports special actions. Index 0 ("Unknown") is still left out on purpose.
Checked and not changed
A bug hunt also flagged two other things. Both match upstream, so they're left alone:
set_active on the Resolution interface: ratbagd defines SetActive there (ratbagd/ratbagd-resolution.c:358).
memory_offset overlap test: liquidctl's _get_bucket_memory_offset has the same endByte > startByte check.
Tests
New mouse::tests::special_choices_cover_every_entry.
Action::choices stopped one entry short of SPECIALS, so the last special
action never showed in the button combo box.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.
The button combo box now offers the Battery level action, which was previously omitted. Unknown stays excluded. No concrete merge-blocking risk was identified, though the change was not tested on real hardware.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly describes the change to offer the Battery level special action.
Docstring Coverage
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Reviewing files that changed from the base of the PR and between 31da907 and 0e1dff8.
Files selected for processing: 1
src/mouse.rs
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Action::choices(src/mouse.rs:74) used1..SPECIALS.len() - 1, which skips the last entry. So "Battery level" was never offered for a button that supports special actions. Index 0 ("Unknown") is still left out on purpose.Checked and not changed
A bug hunt also flagged two other things. Both match upstream, so they're left alone:
set_activeon the Resolution interface: ratbagd definesSetActivethere (ratbagd/ratbagd-resolution.c:358).memory_offsetoverlap test: liquidctl's_get_bucket_memory_offsethas the sameendByte > startBytecheck.Tests
mouse::tests::special_choices_cover_every_entry.cargo test: 8 passed.cargo clippy --all-targets -D warnings: clean.🤖 Generated with Claude Code
Summary by CodeRabbit