Sourcery refactored master branch#13
Open
sourcery-ai[bot] wants to merge 1 commit into
Open
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Comment on lines
-17
to
+27
| # Checks if filename is compliant with Jekyll blog posts | ||
| if _re_blog_date.match(nb_path.name): return nb_path.with_suffix('.md').name.replace(' ', '-') | ||
|
|
||
| else: | ||
| clean_name = _re_numdash.sub('', nb_path.with_suffix('.md').name).replace(' ', '-') | ||
| if _re_blog_date.match(nb_path.name): | ||
| if _re_blog_date.match(nb_path.name): return nb_path.with_suffix('.md').name.replace(' ', '-') | ||
| clean_name = _re_numdash.sub('', nb_path.with_suffix('.md').name).replace(' ', '-') | ||
|
|
||
| # Gets the file's last modified time and and append YYYY-MM-DD- to the beginning of the filename | ||
| mdate = os.path.getmtime(nb_path) - 86400 # subtract one day b/c dates in the future break Jekyll | ||
| dtnm = datetime.fromtimestamp(mdate).strftime("%Y-%m-%d-") + clean_name | ||
| assert _re_blog_date.match(dtnm), f'{dtnm} is not a valid name, filename must be pre-pended with YYYY-MM-DD-' | ||
| # push this into a set b/c _nb2htmlfname gets called multiple times per conversion | ||
| if warnings: warnings.add((nb_path, dtnm)) | ||
| return dtnm | ||
| # Gets the file's last modified time and and append YYYY-MM-DD- to the beginning of the filename | ||
| mdate = os.path.getmtime(nb_path) - 86400 # subtract one day b/c dates in the future break Jekyll | ||
| dtnm = datetime.fromtimestamp(mdate).strftime("%Y-%m-%d-") + clean_name | ||
| assert _re_blog_date.match(dtnm), f'{dtnm} is not a valid name, filename must be pre-pended with YYYY-MM-DD-' | ||
| # push this into a set b/c _nb2htmlfname gets called multiple times per conversion | ||
| if warnings: warnings.add((nb_path, dtnm)) | ||
| return dtnm |
Author
There was a problem hiding this comment.
Function rename_for_jekyll refactored with the following changes:
- Remove unnecessary else after guard condition (
remove-unnecessary-else)
This removes the following comments ( why? ):
# Checks if filename is compliant with Jekyll blog posts
Comment on lines
-5
to
+6
| assert draft_url, 'Was not able to find Draft URL in the logs:\n{}'.format(logs) | ||
| print("::set-output name=draft_url::{}".format(draft_url)) | ||
| assert draft_url, f'Was not able to find Draft URL in the logs:\n{logs}' | ||
| print(f"::set-output name=draft_url::{draft_url}") |
Author
There was a problem hiding this comment.
Lines 5-6 refactored with the following changes:
- Replace call to format with f-string [×2] (
use-fstring-for-formatting)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!