[pull] main from google:main - #25
Merged
Merged
Conversation
PiperOrigin-RevId: 963980831 Change-Id: If6451568a16f58f7d028996107b8d8d302e6d33f
- Remove the `StatementOrThrow` and `ExecuteOrThrow` methods from the SQLite wrapper - Replace exception-based error handling with `absl::Status` and `absl::StatusOr` - Replace try-catch blocks with `ABSL_RETURN_IF_ERROR` and `ABSL_ASSIGN_OR_RETURN` macros across the database writer, reader, and IDA plugin code. Additionally, introduce a `ShowWarningAndReturn` helper to handle UI warnings on failure We will probably need more refactorings to separate how/when we show UI messages and when/what we will log. PiperOrigin-RevId: 964092040 Change-Id: I5037e8fc64b354b134ffce881585a887337ec784
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )