feat: coop management - #822
Open
crosspolar wants to merge 8 commits into
Open
Conversation
Theophile-Madet
left a comment
Collaborator
There was a problem hiding this comment.
I'm not sure it's worth the added complexity for something that changes every 5 years, but if we do want it, could we make it more generic?
Instead of a CoopAddress model we could have something like
class CustomizableString(models.Model):
key = models.CharField(...)
value = models.CharField(...)Where the list of keys is defined as constants, and the keys are coop_name, coop_full_name...
That would let us add more strings by adding a constant and we're not bound to the CoopAddress name so we can put other things in it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I figured, it would be nice if Vorstand is not relying on us to change the address of SuperCoop :). could superseed #819