feat: watch abcd shift by qualification - #805
Merged
Merged
Conversation
# Conflicts: # tapir/translations/locale/de/LC_MESSAGES/django.po
crosspolar
marked this pull request as ready for review
June 16, 2026 20:04
Contributor
Author
|
The UX in createRecurringShiftWatch is aweful I have to admit |
Theophile-Madet
requested changes
Jun 25, 2026
Theophile-Madet
left a comment
Theophile-Madet
left a comment
Collaborator
There was a problem hiding this comment.
The code is fine, but shouldn't there be changes in ShiftWatchCreator._filter_shifts_for_recurring so that only shifts with the selected qualifications are watched?
Also in send_shift_watch_mail, so that it only sends mails about the selected slots, not any slots?
# Conflicts: # tapir/translations/locale/de/LC_MESSAGES/django.po
… watched_capability if user wants to
This reverts commit 4798188.
# Conflicts: # tapir/translations/locale/de/LC_MESSAGES/django.po
crosspolar
changed the title
Contributor
Author
|
|
Theophile-Madet
previously approved these changes
Jul 27, 2026
# Conflicts: # tapir/translations/locale/de/LC_MESSAGES/django.po
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed #790