fix(security): disable Netty wire logging in lms service - #48
Open
pallakartheekreddy wants to merge 1 commit into
Open
fix(security): disable Netty wire logging in lms service#48pallakartheekreddy wants to merge 1 commit into
pallakartheekreddy wants to merge 1 commit into
Conversation
play.server.netty.log.wire was `true` in the lms service conf. Wire logging emits full request/response bytes -- headers (including x-authenticated-* identity/tokens) and bodies (user PII) -- into the logs. Set log.wire = false. Config-only change; no code or API impact. Log-hygiene slice (quick-win #3) of the lern-service design.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Log-hygiene slice for lern-service (PLAN.md quick-win #3).
play.server.netty { log.wire = true }in the lms service conf caused Netty wire logging to emit full request/response bytes — headers (includingx-authenticated-*identity headers / bearer tokens) and bodies (user PII) — into the application logs.The change
log.wire = falseinmodules/lms/service/conf/application.conf. Config-only — no code or API impact.Note: the working tree had unrelated pre-existing
build/*deletions; this branch contains only thelog.wirechange. The broader lern-service log-hygiene items (secret-value logging viaUtil.readValue, full-payload INFO logs) and the critical PII-crypto / SSTI / PII-read-authZ findings are larger, higher-touch changes tracked separately.