Skip to content

updated exception handling #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sntiwari1 merged 1 commit into from
Nov 7, 2025
Merged

updated exception handling #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions all-actors/src/main/java/org/sunbird/serviceimpl/CertsServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ private Response processRecord(Map<String, Object> certReqAddMap, String version
Map<String,Object>recordMap= requestMapper.convertValue(certificate,Map.class);
return CertificateUtil.insertRecord(recordMap, certBackgroundActorRef);
}
private Certificate getCertificate(Map<String, Object> certReqAddMap) {
private Certificate getCertificate(Map<String, Object> certReqAddMap) throws BaseException {
Object relatedObj = certReqAddMap.get(JsonKeys.RELATED);
if (relatedObj == null) {
throw new BaseException(IResponseMessage.INVALID_REQUESTED_DATA, MessageFormat.format(getLocalizedMessage(IResponseMessage.MISSING_MANDATORY_PARAMS,null), JsonKeys.RELATED), ResponseCode.CLIENT_ERROR.getCode());
Expand Down Expand Up @@ -161,7 +161,7 @@ private Recipient getCompositeReciepientObject(Map<String, Object> certAddReques
return recipient;
}

private Map<String, Object> getData(Map<String, Object> certAddRequestMap) {
private Map<String, Object> getData(Map<String, Object> certAddRequestMap) throws BaseException {
Object jsonDataObj = certAddRequestMap.get(JsonKeys.JSON_DATA);
if (jsonDataObj instanceof scala.collection.Map) {
return (Map<String, Object>) CollectionConverters.asJava((scala.collection.Map<?, ?>) jsonDataObj);
Expand Down