Classify ownerOf reverts by revert data, not error variant#66
Merged
Conversation
get_positions_by_owner skips burned/non-existent tokens by catching the ownerOf revert, but how a revert surfaces is provider-dependent: some RPC providers decode it into a contract error, others wrap the raw JSON-RPC error response (code 3, revert data attached) as a transport error. The scan treated the latter as a network failure and aborted the enumeration on any market with a burned position. Recognize reverts by the presence of revert data on the error response and skip them regardless of encoding; only genuine transport failures (no revert payload) propagate.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughModified error handling in ChangesBurned-token detection fix
Estimated code review effort: 2 (Simple) | ~10 minutes Estimated code review effortEstimated code review effort: 2 (Simple) | ~10 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit