Gate Cypress workflow on 'run e2e tests' label to match pro - #3254
Conversation
We were burning CI minutes running the full Cypress suite on every PR event. The formidable-pro repo's own cypress.yml already gates on the 'run e2e tests' label; align formidable-forms with the same pattern instead of the looser 'run tests' label it was using. Closes Strategy11/formidable-pro#6566
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| PHP | Aug 18, 2026 5:16p.m. | Review ↗ | |
| JavaScript | Aug 18, 2026 5:16p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
There was a problem hiding this comment.
Clean, verified. Confirmed the claimed match against formidable-pro's cypress.yml directly: line 20 there uses the identical contains(github.event.pull_request.labels.*.name, 'run e2e tests') expression, so this isn't a hand-invented gate. Also confirmed the scope note is accurate — phpunit.yml's own label gate here is untouched, still 'run tests', so this PR only tightens the Cypress trigger as claimed. CI on this PR shows Cypress skipping, exactly the expected behavior since this branch doesn't carry run e2e tests — the change proves itself on its own PR. No functional/security surface (boolean workflow condition, no shell interpolation, no secrets/permissions touched). Not a manual-test surface, so no reviewer request.
What was broken
The Cypress E2E workflow in this repo (
.github/workflows/cypress.yml) triggered on any PR carrying therun testslabel — a much broader/looser label than intended, burning CI minutes running the full browser E2E suite more often than needed.What changed
Updated the job's
if:gate from:to:
This matches the exact syntax and label already used by the working, already-shipped equivalent in the sibling repo
Strategy11/formidable-pro's own.github/workflows/cypress.yml(line 20 there uses the identical expression with'run e2e tests').Scope note:
.github/workflows/phpunit.ymlin this repo also currently uses the looser'run tests'label, but the issue is specifically about the Cypress workflow (the CI-minutes-heavy one), sophpunit.ymlwas left untouched to keep this diff scoped to the reported problem.How verified
cypress.ymldirectly to confirm the exactif:expression syntax and label string, rather than hand-writing a new one.python3 -c "import yaml; yaml.safe_load(...)").if:gate will be visible on this very PR's own Actions run (Cypress should report "skipped" here since this branch doesn't carry therun e2e testslabel — the same behavior formidable-pro's own PRs already exhibit).Closes Strategy11/formidable-pro#6566