Skip to content

Gate Cypress workflow on 'run e2e tests' label to match pro - #3254

Merged
stephywells merged 1 commit into
masterfrom
fix/issue-6566-cypress-run-e2e-tests-label
Aug 18, 2026
Merged

Gate Cypress workflow on 'run e2e tests' label to match pro#3254
stephywells merged 1 commit into
masterfrom
fix/issue-6566-cypress-run-e2e-tests-label

Conversation

@vivi-the-going-merry

Copy link
Copy Markdown
Contributor

What was broken

The Cypress E2E workflow in this repo (.github/workflows/cypress.yml) triggered on any PR carrying the run tests label — a much broader/looser label than intended, burning CI minutes running the full browser E2E suite more often than needed.

What changed

Updated the job's if: gate from:

if: contains(github.event.pull_request.labels.*.name, 'run tests')

to:

if: contains(github.event.pull_request.labels.*.name, 'run e2e tests')

This matches the exact syntax and label already used by the working, already-shipped equivalent in the sibling repo Strategy11/formidable-pro's own .github/workflows/cypress.yml (line 20 there uses the identical expression with 'run e2e tests').

Scope note: .github/workflows/phpunit.yml in this repo also currently uses the looser 'run tests' label, but the issue is specifically about the Cypress workflow (the CI-minutes-heavy one), so phpunit.yml was left untouched to keep this diff scoped to the reported problem.

How verified

  • Read formidable-pro's already-working cypress.yml directly to confirm the exact if: expression syntax and label string, rather than hand-writing a new one.
  • Validated the edited YAML parses correctly (python3 -c "import yaml; yaml.safe_load(...)").
  • Self-reviewed: no reuse/simplification/efficiency/altitude issues (single string-literal change mirroring an already-shipped pattern); security review confirmed no injection/privilege-escalation surface (boolean expression, not shell-interpolated, no permissions/secrets touched).
  • This is a CI trigger-condition-only change with no code path to red/green locally; correctness of the if: gate will be visible on this very PR's own Actions run (Cypress should report "skipped" here since this branch doesn't carry the run e2e tests label — the same behavior formidable-pro's own PRs already exhibit).

Closes Strategy11/formidable-pro#6566

We were burning CI minutes running the full Cypress suite on every PR
event. The formidable-pro repo's own cypress.yml already gates on the
'run e2e tests' label; align formidable-forms with the same pattern
instead of the looser 'run tests' label it was using.

Closes Strategy11/formidable-pro#6566
@deepsource-io

deepsource-io Bot commented Aug 18, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 1c96d35...137871c on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Aug 18, 2026 5:16p.m. Review ↗
JavaScript Aug 18, 2026 5:16p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@franky-the-going-merry franky-the-going-merry Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, verified. Confirmed the claimed match against formidable-pro's cypress.yml directly: line 20 there uses the identical contains(github.event.pull_request.labels.*.name, 'run e2e tests') expression, so this isn't a hand-invented gate. Also confirmed the scope note is accurate — phpunit.yml's own label gate here is untouched, still 'run tests', so this PR only tightens the Cypress trigger as claimed. CI on this PR shows Cypress skipping, exactly the expected behavior since this branch doesn't carry run e2e tests — the change proves itself on its own PR. No functional/security surface (boolean workflow condition, no shell interpolation, no secrets/permissions touched). Not a manual-test surface, so no reviewer request.

@stephywells
stephywells merged commit 3aaafd2 into master Aug 18, 2026
30 checks passed
@stephywells
stephywells deleted the fix/issue-6566-cypress-run-e2e-tests-label branch August 18, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant