Resolve #4 (repo hygiene) and #5 (registered .Call symbol)#11
Merged
Conversation
Remove .Rhistory (can leak local paths) and .DS_Store from version control and add .Rhistory to .gitignore/.Rbuildignore (.DS_Store and .claude/ were already ignored). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
useDynLib(pikchr, pikchr_c) + .Call(pikchr_c, ...) instead of the string-based lookup, matching the routine registered in src/init.c. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4 — Repo hygiene
.Rhistory(can leak local paths) and.DS_Store..Rhistoryto.gitignoreand.Rbuildignore(.DS_Storeand.claude/were already ignored).#5 — Registered native symbol
useDynLib(pikchr, pikchr_c)+.Call(pikchr_c, ...)instead of the string lookup, matching the routine registered insrc/init.c. Verifiedpikchr()still returns valid SVG viadevtools::load_all().Also records the CRAN submission of 1.1.1 in
CRAN-SUBMISSION(fromsubmit_cran()).Closes #4
Closes #5
🤖 Generated with Claude Code