Repository navigation
fix(objects,viewport): spell-book field collapse + resize hardening - #31
Merged
Merged
Conversation
Object editor — a Spell Book's data fields (spb1 Spell List / spb2 Shared
Cooldown / spb3 Min / spb4 Max / spb5 Base Order) are distinct FourCCs that
share ONE SLK column name ("Data"), so the merged-view + get path collapsed
them onto a single slot — setting one overwrote all four. Key shared columns
by FourCC in applyOverrides/applyLevelOverrides/getObject (the on-disk shadow
already keys by FourCC, so existing maps are intact on disk). Adds a SharedCols
set to ObjectMetadata + TestSpellBook_DataFieldsDoNotCollapse regression test.
Viewport resize hardening — the agent-console-resize distortion could NOT be
reproduced (aspect changes only scale horizontally; terrain + instances share
one view-projection matrix), but these are safe correctness improvements:
- BridgeConsole gets flex-shrink:0 so it honors its drag height.
- camera.setAspect skips only on exact equality (no aspect lag mid-drag).
- instance-outline restores the full-canvas gl.viewport after its pass.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spell-book object-data field collapse (confirmed fix)
A Spell Book ability's data fields (
spb1Spell List,spb2,spb3Min,spb4Max,spb5Base Order) are distinct FourCCs sharing one SLK column name ("Data"). The merged-view + get path keyed by column name, so they collapsed — setting one overwrote all. Now shared columns key by FourCC inapplyOverrides/applyLevelOverrides/getObject. The on-disk shadow already keyed by FourCC, so existing maps are intact on disk. AddedSharedColstoObjectMetadata+TestSpellBook_DataFieldsDoNotCollapse. Verified live: setting spb1/spb3/spb4 to distinct values now stays distinct.Viewport resize hardening (candidate — root cause not reproduced)
The agent-console-resize distortion could not be reproduced (aspect only scales horizontally; terrain + instances share one matrix), but these are safe improvements: BridgeConsole
flex-shrink:0, exact-equality aspect skip, restored full-canvas viewport after the selection-outline pass.Verify:
go vet,go test ./internal/forge/...,npm run check,wails buildall green.Ships as v1.0.2.
🤖 Generated with Claude Code