Repository navigation
Allow Rock to open a pane through OSC 7880 - #84
Draft
StephenSHorton wants to merge 5 commits into
Draft
StephenSHorton wants to merge 5 commits into
StephenSHorton wants to merge 5 commits into
Conversation
The fork host now accepts an absolute rock binary. That launch sets ROCK_SESSION_TITLE and skips the Grok launcher environment.
The previous commit on this branch left a placeholder in the OSC parser. This restores the allowlist, ROCK_SESSION_TITLE launch env, and the tests.
The file is the tested allowlist again: rock is accepted, ROCK_SESSION_TITLE is set, and half_size keeps its return type.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suzuri's OSC 7880 host now accepts an absolute
rockbinary. A launch whose stem isrocksetsROCK_SESSION_TITLEand does not set theGROK_*launcher environment. Grok binaries keep the existing env.The allowlist still requires an absolute path with no
... A barerockis rejected.cargo test --lib fork_oscpassed with this change (15 tests), includingallowlistandlaunch_spec_rock_uses_rock_title_env. Windows assertions stay behindcfgso CI on Windows does not see a Unix path.