Repository navigation
feat(block): implementing shelf mushroom block (26.3) - #756
Merged
Merged
Conversation
aure31
changed the title
aure31
marked this pull request as ready for review
October 11, 2026 19:30
Contributor
|
LGTM Tested in-game:
Everything matches Vanilla |
Joniii11
suggested changes
Oct 13, 2026
Joniii11
left a comment
Joniii11
left a comment
Contributor
There was a problem hiding this comment.
this is what i found which is important
Joniii11
suggested changes
Oct 13, 2026
Joniii11
left a comment
Joniii11
left a comment
Contributor
There was a problem hiding this comment.
this is just some nitpicking most of it some are some good things mabe idk
Joniii11
approved these changes
Oct 13, 2026
Joniii11
left a comment
Joniii11
left a comment
Contributor
There was a problem hiding this comment.
LGTM well done thank you very much! :)
JunkyDeveloper
force-pushed
the
shelf-mushroom
branch
from
October 13, 2026 23:11
f1762d1 to
bfc5efb
Compare
|
This pull request has conflicts with the base branch "master". Please resolve those so we can test out your changes. |
|
Conflicts have been resolved! 🎉 |
JunkyDeveloper
requested changes
Oct 15, 2026
Contributor
Author
|
@JunkyDeveloper it's fix |
coco875
requested changes
Oct 18, 2026
JunkyDeveloper
previously approved these changes
Oct 18, 2026
github-actions
Bot
added
approved-by-junkydeveloper
and removed
changes-requested-by-junkydeveloper
labels
JunkyDeveloper
approved these changes
Oct 19, 2026
Joniii11
approved these changes
Oct 19, 2026
coco875
approved these changes
Oct 19, 2026
github-actions
Bot
added
approved-by-coco875
approved-by-junkydeveloper
and removed
changes-requested-by-coco875
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
implement the new shelf mushroom block and the new block config that goes with it. Also matching bouncing logic with vanilla
it add the new fallDistanceReduction property to blocks:
Steel-Foundation/SteelExtractor#31
How this was tested
ingame testing
Screenshots / logs
Checklist
Classes / commands modified:
Additional notes