fix steamcmd writing to HOME dir & add sanitycheck - #91
Merged
Conversation
…ot shit files into the actual users Home
…annot write to workdir
…ng wrong wd in testing
…ow running as root in docker container. Added getter and setter acordingly.
JacksonTheMaster
left a comment
JacksonTheMaster
left a comment
Member
Author
There was a problem hiding this comment.
reviewed, I like my own PR ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some checks to detect user misconfigurations such as running as root, wrong workdirs and most importantly if the SSUI dir (main dir) is unwritable.
It also introduces logic to set the env var of HOME to the current DIR exclusively for steamcmd commands so steamcmd does not write or rely on files in the ~/Steam folder.
This also adds a IsDockerContainer (defaults to false) var (with getters and setters for future use) and a -SkipSteamCMD / -nosteam (alias) CLI arg.