Added a check to prevent a world name with spaces - #88
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds validation to prevent world names with spaces during the world creation wizard process and updates the version number to 5.6.6.
- Added space validation check for world names in the onboarding form
- Updated application version from 5.6.5 to 5.6.6
- Displays error notification when spaces are detected in world names
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/config/config.go | Version bump to 5.6.6 |
| UIMod/onboard_bundled/twoboxform/twoboxform.js | Added space validation for world names with error handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
mitoskalandiel
previously approved these changes
Sep 19, 2025
mitoskalandiel
left a comment
mitoskalandiel
left a comment
Contributor
There was a problem hiding this comment.
Yeah makes sense, since all worldtypes are strings with no spaces..
Member
Pretty much, this fixes the world name because the arg parsing breaks when we use -file start My Save Mars2 because the dedi then tries to use "Save" as the worldID and Mars2 as the difficulty :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Bugfixes