Feat server advertisement - #112
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds server advertisement functionality to allow the application to advertise servers behind reverse proxies. The feature introduces a new command-line flag --OverrideAdvertisedIp that sets a custom IP address for server advertisement while disabling the built-in server visibility to prevent conflicts.
- Added
OverrideAdvertisedIpconfiguration option with getter/setter functions and persistence - Implemented automatic server advertisement service that posts server info to a discovery endpoint
- Added command-line flag support for setting the override IP address
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/core/loader/cmdargs.go | Adds command-line flag parsing for override advertised IP |
| src/config/vars.go | Declares new OverrideAdvertisedIp configuration variable |
| src/config/setters.go | Implements setter function for the override IP configuration |
| src/config/getters.go | Implements getter function for the override IP configuration |
| src/config/config.go | Adds JSON serialization support and configuration loading for override IP |
| src/advertiser/advertiser.go | New advertiser service that handles server advertisement functionality |
| server.go | Integrates advertiser service startup in main application |
| .vscode/launch.json | Adds debug configuration for testing the new override IP feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: JLangisch <jakob.langisch@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Comments suppressed due to low confidence (1)
src/config/config.go:1
- Typo in comment: 'secconds' should be 'seconds'.
package config
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
JacksonTheMaster
left a comment
There was a problem hiding this comment.
reviewed, merged as discussed in VC
Feat server advertisement
New features: