Skip to content

Adds smoke-test and github action to run it - #111

Closed
1Solon wants to merge 8 commits into
nightlyfrom
feat-arch-run-test
Closed

Adds smoke-test and github action to run it#111
1Solon wants to merge 8 commits into
nightlyfrom
feat-arch-run-test

Conversation

@1Solon

@1Solon 1Solon commented Sep 29, 2025

Copy link
Copy Markdown
Contributor

Introduces a smoke test ran on each PR, which builds and runs the application on various operating systems. This should catch any issues that occur between OS's and allow us to confidently state support for various Linux Distributions.

Copilot AI review requested due to automatic review settings September 29, 2025 20:00
@1Solon 1Solon added the enhancement New feature or request label Sep 29, 2025
@1Solon
1Solon requested review from JacksonTheMaster and removed request for Copilot September 29, 2025 20:01
@1Solon 1Solon self-assigned this Sep 29, 2025
Copilot AI review requested due to automatic review settings September 29, 2025 20:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a comprehensive cross-platform smoke testing workflow that validates the application can build and run successfully across different operating systems and Linux distributions. The automation runs on every pull request to catch platform-specific compatibility issues early.

Key changes:

  • Adds GitHub Actions workflow for cross-OS smoke testing on Ubuntu and Windows
  • Includes containerized testing for specific Linux distributions (Debian, Arch Linux)
  • Implements automated result collection and PR commenting with test summaries

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/pr-smoke-test.yml Main workflow definition with multi-OS matrix testing and result summarization
.github/scripts/run-smoke.sh Bash script that builds, starts, and validates the application server

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread .github/workflows/pr-smoke-test.yml Outdated
Comment thread .github/scripts/run-smoke.sh Outdated
Comment thread .github/scripts/run-smoke.sh Outdated
@SteamServerUI SteamServerUI deleted a comment from github-actions Bot Sep 29, 2025
@SteamServerUI SteamServerUI deleted a comment from github-actions Bot Sep 29, 2025
@1Solon

1Solon commented Sep 29, 2025

Copy link
Copy Markdown
Contributor Author

Apologies for all the force pushing- testing GitHub actions is pain

@JacksonTheMaster
JacksonTheMaster removed their request for review September 29, 2025 21:27
@JacksonTheMaster

Copy link
Copy Markdown
Member

pls request a review when this is actually ready for review :)

@1Solon

1Solon commented Sep 29, 2025

Copy link
Copy Markdown
Contributor Author

pls request a review when this is actually ready for review :)

It is ready to review.

Comment thread .github/workflows/pr-smoke-test.yml Outdated
Comment thread .github/scripts/run-smoke.sh Outdated
Comment thread .github/scripts/run-smoke.sh Outdated
Comment thread .github/scripts/run-smoke.sh
@1Solon

1Solon commented Oct 2, 2025

Copy link
Copy Markdown
Contributor Author

@JacksonTheMaster you mentioned that this was unmergable in DMs, could you indicate to me what the reason for this is- and what steps to resolution you would like?

@JacksonTheMaster

Copy link
Copy Markdown
Member

@JacksonTheMaster you mentioned that this was unmergable in DMs, could you indicate to me what the reason for this is- and what steps to resolution you would like?

If steamcmd fails, the smoke test still shows successful. Steps to resolution? None, at the moment.

@1Solon

1Solon commented Oct 2, 2025

Copy link
Copy Markdown
Contributor Author

@JacksonTheMaster you mentioned that this was unmergable in DMs, could you indicate to me what the reason for this is- and what steps to resolution you would like?

If steamcmd fails, the smoke test still shows successful. Steps to resolution? None, at the moment.

Could you indicate where this was shown? The tests themselves show steamcmd ran, see below:
image
Edited: wording

@JacksonTheMaster

Copy link
Copy Markdown
Member

closing this for now, needs more work regarding steamcmd as discussed internally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants