Saveinfo rework - #100
Merged
Merged
Conversation
…discussion_r2368759050 by reworking the SaveInfo field into two seperate fields. Initial testing confirms desired functionality, though way more testing for backwards compatibility and general functionality (also in preterrain) is required to harden this. The localization also needs to be updated.
…don't save SaveInfo back to config.json.
Member
Author
|
Seb reviewed this, but apparently forgot to apply a reviewed mark. merging.. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of the dated "SaveInfo" field, we now have two fields, one for the Save name (supporting spaces) and a seperate field for WorldID