Add whmcs-capsule-orm, security-insecure-session, security-race-condition rules#7
Open
mladenovic-13 wants to merge 1 commit into
Open
Add whmcs-capsule-orm, security-insecure-session, security-race-condition rules#7mladenovic-13 wants to merge 1 commit into
mladenovic-13 wants to merge 1 commit into
Conversation
…tion rules Add whmcs-capsule-orm (detects raw PDO/mysqli instead of Capsule ORM), security-insecure-session (detects insecure PHP session ini_set and session_set_cookie_params), and security-race-condition (TOCTOU CWE-367, detects file_exists/is_dir followed by file operation within 5 lines).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add three rules covering WHMCS best practices, PHP session security,
and cross-platform TOCTOU race conditions.
Summary
whmcs-capsule-orm— detects raw PDO/mysqli database access, recommends WHMCS Capsule ORMsecurity-insecure-session— detects insecure PHP session config (use_trans_sid,cookie_secure=false, etc.)security-race-condition— detects TOCTOU patterns (file_existsfollowed by file operation within 5 lines, CWE-367)insecure_sessions.php) for CLI demoType of Change
Checklist
npm run validatepasses (lint + typecheck + tests + build)anytypes introduced