Add security-insecure-random rule for PHP/WHMCS modules#3
Merged
Conversation
Detect cryptographically weak PRNG (rand, mt_rand, uniqid, microtime, time) used for security-sensitive values like tokens, keys, secrets, nonces, and CSRF tokens. Two complementary patterns: security-named variable assignment and hash-wrapping weak random. Skips lines with safe alternatives (random_bytes, random_int, openssl_random_pseudo_bytes).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect cryptographically weak PRNG (rand, mt_rand, uniqid, microtime,
time) used for security-sensitive values like tokens, keys, secrets,
nonces, and CSRF tokens. Skips lines with safe alternatives
(random_bytes, random_int, openssl_random_pseudo_bytes).
Summary
security-insecure-randomrule detecting CWE-338 vulnerabilities in PHP/WHMCS modulesinsecure_random.php) for CLI demoType of Change
Checklist
npm run validatepasses (lint + typecheck + tests + build)anytypes introduced