Skip to content

Feature dev prof 1 - #81

Closed
Anas-Sneo wants to merge 2 commits into
developfrom
feature-dev-prof-1
Closed

Anas-Sneo wants to merge 2 commits into
developfrom
feature-dev-prof-1

Conversation

@Anas-Sneo

@Anas-Sneo Anas-Sneo commented Nov 12, 2025

Copy link
Copy Markdown

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Database change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  • Unit Tests
  • Integration Tests
  • Manual Testing (please describe)

Checklist:

  • I have created ADR (Architecture Decision Record) for this change, in case of architecture or tech stack changes.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes in other branches have been merged
  • I have updated the relevant application properties files (if needed)
  • I have updated any necessary database migrations (if needed)

Screenshots (for UX changes):

Additional Notes:

These changes are for #75
Please add any additional notes, dependencies, or context that reviewers should know about.

@Anas-Sneo
Anas-Sneo requested a review from axymthr November 12, 2025 08:38
@Configuration
public class AppConfig {

@Bean

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use RestTemplate, use the newer RestClient. I replaced the production code to use RestClient

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach isn't appropriate. Create settings for the dev profile, don't make sqlite into the dev profile.

@@ -1,4 +1,6 @@
spring:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't do this, create a separate dev profile file.

Comment thread web-backend/README.md

1. **Database**: PostgreSQL is used as the primary database
- **Optional**: SQLite can be used for development/testing (see [SQLite Persistence](docs/sqlite-persistence.md))
1. **Database**:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still wrong.

@Anas-Sneo Anas-Sneo closed this Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants