rss_analysis: effective sample size for case/control GWAS - #1391
Merged
Conversation
construct.R attaches per-variant n_case/n_control (N_CASE/N_CONTROL) and no longer requires a precomputed N when they are present; --effective-n (default on) forwards to summaryStatsQc(effectiveN=). Study-level fallback: gwas_rss_manifest.R carries n_case/n_control from --gwas-meta into the manifest and the construct step forwards them as --n-case/--n-control. effective_n exposed in rss_analysis.ipynb.
danielnachun
force-pushed
the
gwas-effective-n
branch
from
July 21, 2026 04:37
40e91d3 to
f000a7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires per-variant n_case/n_control (and a --gwas-meta study-level fallback) into rss_analysis so case/control GWAS use effective N. Depends on pecotmr's effective-N PR (effectiveN() + summaryStatsQc(effectiveN=)); needs pecotmr reinstalled from merged main before running. Validated in test_run/gwas_effective_n_test/VALIDATION.md.