Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I have added a CI system so that we can actually test some of our notebooks when we make PRs to change them. Here are the details:
pytestas the unit-testing framework. This is a Python-based framework which can be used to unit test any language, not just Pythontestthatand assessed for coverage withcovr, but we have also discussed that we want our R scripts which interact withpecotmrto just be thing wrappers that process arguments, read and write results and make plots. For this reason at the moment we aren't doing anything other than just running them with the test data, though if we end up needing to keep more complex scripts in the pipeline in the future, we may have to usetestthatandcovrfor them.pecotmrversion is currently pinned the latest stable conda package. We probably want to stick to this, but we could also build the latest package from source if we prefer that.