fix(container-runtime): drop prettier from the build script#3467
Merged
Conversation
Since #3437 removed the local prettier config, prettier invoked from inside container-runtime resolves the root .prettierrc.json (config files walk up) but not the root .prettierignore (ignore files resolve from the cwd), so every build rewrote the __fixtures__/ files the ignore protects. Remove the prettier --write from the build script, the local format scripts, and the prettier devDependency; formatting runs through web-format from the repo root instead. Make start-os-format Rust-only to match the other products, update the docs that still described the pre-#3437 double-quote config, and sync the lockfile's SDK dist version to 2.0.3.
MattDHill
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every StartOS build was rewriting
container-runtime/src/**/__fixtures__/*.tsfrom double quotes to single quotes.Root cause: the container-runtime
buildscript ranprettier . --writefrom inside the project directory. Since #3437 removed the local prettier config, that invocation resolves the root.prettierrc.json(config files walk up the tree) but not the root.prettierignore(ignore files only resolve from the cwd) — so the**/__fixtures__/protection never applied. Verified withprettier --file-info: the same fixture file reportsignored: falsefrom the project cwd andignored: truefrom the repo root.make start-os-format/-checkhad the same bug via the localformat/format:checknpm scripts.Fix
buildscript is now justrm -rf dist && tsc; the localformat/format:checkscripts and theprettierdevDependency are removed — one root prettier config, no per-component prettier surface.start-os-format/start-os-format-checkare Rust-only, matching start-wrt/start-tunnel; TS formatting for web + container-runtime runs throughweb-format(root cwd, so the ignore applies).projects/start-os/{AGENTS,CONTRIBUTING}.mdandcontainer-runtime/{AGENTS,CONTRIBUTING}.md.file:SDK dist entry to 2.0.3 (matches the SDK version at HEAD).No changelog entry — build tooling only, nothing user-visible.
Verification
npm run buildexits 0 and leaves the tree untouched (fixtures stay double-quoted)npx prettier --checkfrom the root passes over container-runtime and the edited docsmake -n start-os-format start-os-format-checkparses and shows the expected Rust-only recipes