Repository navigation
Conversation
Remove the spoiler switch from ContentSettings and ignore the Spoiler URL parameter and stored preference. Keep unreleased content hidden by default, show the shared notice on unreleased story chapter pages, and update the five core locale copy and tests.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the public spoiler toggle and the URL/stored-preference unlock path. Keep unreleased content hidden by default, and show the shared unreleased-content notice on locked chapter pages.
Changes
SpoilerTogglefromContentSettings.?Spoiler=allowand the local-storage preference no longer enable unreleased content.Verification
bun run lint— passbun run check— passbun run check:search-seo— passbun test tests/spoiler-settings.test.tsx— 3 passbun test tests/— 1011 pass, 1 skip, 0 fail (includes the Haneoka 7c167c95 WASM engine test; the skip is the Linux-only GNU time test)bun run build— passRollback
Revert
0e66474bac958dc5d0d382e9de921e8188e9d68d.