Repository navigation
feat(deck): hydrate missing live charts from moenotes-assets - #103
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/v1/meta/deck-charts): Whennnnotes'smusic-data.ymlbuild lags or fails, newly releasedMasterLiveMusicdifficulties (including Challenge Event valuation songs) are now automatically hydrated frommoenotes-assets(Live/MusicScore/<chartKey>/<score>.json) instead of blocking the deck builder onsolver.dataUpdating(组卡数据更新中。).runtime_chart::convertparity (src/lib/deck/chart-convert.ts): Converts plain UTF-8 or gzippedss scoreJSON with.NETmidpoint-to-even rounding, binary32 BPM/bar timelines,Creator::line_shapecombo note geometry (judgementAreaOffsetType,lane,width,direction,ease,easeRight,lines),by_keyenumerationordering, fever ranges, andpt.rsplayability checks (durationMs > 0,judgedCount > 0, 5skillEvents).src/lib/masterdata/deck-charts.ts): ResolvesscoreId -> MasterLiveMusicScore._musicScoreTextFileNamestrictly from MasterData, fetches viabuildFetch(respectingMOENOTES_ASSET_INTERNALandforceBypass), falls backkr/en -> twon 404, caches converted charts in bounded LRU memory, and bypasses negative 404 entries onretryorforceBypass.public/deck/deck-worker-core.mjs,src/lib/deck/haneoka/data.ts,src/lib/deck/runtime-source.ts): Batches missingscoreIdsduring Workerinit, merges hydratedcharts+provenance.replay.musicLengthsMs, forwards nativeinputs+enumerationinto Haneoka WASMload_source, and providesresolveLiveDeckRuntimeFallbackwhen externalmusic-datahas no published replay manifest.Verification
bun run lint(i18n, routing, route-registry, architecture, text, emoji, server-config)bun run check(next typegen && tsc --noEmit) &bun run check:search-seobun test(1016passed,0failed across120test files, includingtests/deck-live-chart-hydration.test.ts)