Skip to content

Withdrawal Vulnerability across multiple contracts #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aniket866 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Withdrawal Vulnerability across multiple contracts #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c80fea5
fix-multiple-withdrawn
aniket866 Mar 19, 2026
6794136
fixed-and-added-tests
aniket866 Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion contracts/AllPayAuction.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,10 @@ contract AllPayAuction is Auction {
emit bidPlaced(auctionId, msg.sender, bids[auctionId][msg.sender]);
}

function withdraw(uint256 auctionId) external nonReentrant exists(auctionId) {
function withdraw(uint256 auctionId) external nonReentrant exists(auctionId) onlyAfterDeadline(auctions[auctionId].deadline) {
AuctionData storage auction = auctions[auctionId];
uint256 withdrawAmount = auction.availableFunds;
require(withdrawAmount > 0, 'No funds to withdraw');
auction.availableFunds = 0;
uint256 fees = (auction.protocolFee * withdrawAmount) / 10000;
address feeRecipient = protocolParameters.treasury();
Expand Down
1 change: 1 addition & 0 deletions contracts/EnglishAuction.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ contract EnglishAuction is Auction {
function withdraw(uint256 auctionId) external nonReentrant exists(auctionId) onlyAfterDeadline(auctions[auctionId].deadline) {
AuctionData storage auction = auctions[auctionId];
uint256 withdrawAmount = auction.availableFunds;
require(withdrawAmount > 0, 'No funds to withdraw');
Comment thread
aniket866 marked this conversation as resolved.
auction.availableFunds = 0;
uint256 fees = (auction.protocolFee * withdrawAmount) / 10000;
address feeRecipient = protocolParameters.treasury();
Expand Down
3 changes: 2 additions & 1 deletion contracts/VickreyAuction.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,10 +159,11 @@ contract VickreyAuction is Auction {
function withdraw(uint256 auctionId) external nonReentrant exists(auctionId) onlyAfterDeadline(auctions[auctionId].bidRevealEnd) {
AuctionData storage auction = auctions[auctionId];
uint256 withdrawAmount = auction.availableFunds;
uint256 commitFeeToTransfer = auction.accumulatedCommitFee;
require(withdrawAmount > 0 || commitFeeToTransfer != 0, 'No funds to withdraw');
auction.availableFunds = 0;
uint256 fees = (auction.protocolFee * withdrawAmount) / 10000;
address feeRecipient = protocolParameters.treasury();
uint256 commitFeeToTransfer = auction.accumulatedCommitFee;
sendERC20(auction.biddingToken, auction.auctioneer, withdrawAmount - fees);
sendERC20(auction.biddingToken, feeRecipient, fees);
if (auction.accumulatedCommitFee != 0) {
Expand Down
Loading