feat(card): square map view & configurable flight list position - #40
Open
Springvar wants to merge 11 commits into
Open
feat(card): square map view & configurable flight list position#40Springvar wants to merge 11 commits into
Springvar wants to merge 11 commits into
Conversation
- Add radar.view 'map' option for a full-bleed square map view (falls back to system tiles, hides rings by default with radar.rings override) - Add list.position 'below'|'left'|'right' with CSS container-query fallback to below on narrow cards - Fix pre-existing typecheck and lint issues so tsc and yarn lint pass cleanly
The guarded alias registered 'flightradar24-card' whenever the name was free, but a custom element type can only be registered once. If this card loaded before the Flightradar24 integration's built-in card, the alias claimed the name and the integration's card failed with "the name flightradar24-card has already been used" on every load (issue #41). This card now only registers flightradar24-radar-card. Refs #39, #41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a square map view option and a configurable flight list position, and fixes the pre-existing
tsc/ lint failures so they pass cleanly.Features
radar.view: 'radar' | 'map'(defaultradar)maprenders a full-bleed square Leaflet map instead of the circular radar screen — better for fullscreen and multi-column layouts.systemtiles when nobackground_mapis chosen.radar.ringssetting to control radar grid rings/bearing lines (default off in map view, on in radar view; overridable).list.position: 'below' | 'left' | 'right'(defaultbelow)belowautomatically when the card is too narrow (< ~560px) via CSS container queries — adapts dynamically, no config changes.Fixes (pre-existing)
invalidateSize,_currentMapConfig,LeafletMapOptions.zoomSnap, editoraircraft-markerindexing, browser test cast,vitest.browser.config.tslaunch→launchOptions).Verification
tsc --noEmit: 0 errorseslint .: 0 errorsvitest run: 196 tests passvite build: succeeds