ci(release): build macOS universal binary#17
Merged
Conversation
Matrix defined a platform field for the darwin/universal build but the
build step never consumed it, so the mac job produced a host-arch-only
.app. Wire ${{ matrix.platform }} into wails build so macOS ships a real
universal (arm64 + amd64) binary; Windows/Linux pass empty.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
mateusdemboski
force-pushed
the
ci/macos-universal-build
branch
from
0a7eaec to
d5a6ab6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Wire
${{ matrix.platform }}into thewails buildstep in the release workflow.Why
The desktop matrix already defined
platform: "-platform darwin/universal"for the macOS job, but the build command never referenced it — so the mac job built a host-arch-only.app(whatever the runner happened to be), not a universal binary.Change
${{ matrix.platform }}towails build; macOS now runswails build -platform darwin/universal, producing a real universal (arm64 + amd64).appthat runs on both Apple Silicon and Intel.platform, unchanged..app+ signing).🤖 Generated with Claude Code