Skip to content

Sync combination updates made via legacy Product::updateAttribute() (StoreCommander & bulk tools) #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pichinov-Jose wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Sync combination updates made via legacy Product::updateAttribute() (StoreCommander & bulk tools) #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/splashsync/splashsync.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,8 @@ public function install()
// Register Module Products Attributes Hooks
if (!$this->registerHook('actionObjectCombinationAddAfter') ||
!$this->registerHook('actionObjectCombinationUpdateAfter') ||
!$this->registerHook('actionObjectCombinationDeleteAfter')
!$this->registerHook('actionObjectCombinationDeleteAfter') ||
!$this->registerHook('actionProductAttributeUpdate')
) {
return false;
}
Expand Down
30 changes: 30 additions & 0 deletions modules/splashsync/src/Objects/Product/HooksTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,36 @@ public function hookActionObjectCombinationDeleteAfter(array $params): bool
);
}

/**
* This hook is called when a Product Combination is updated through the legacy
* Product::updateAttribute() path (used by StoreCommander and other bulk catalog
* tools), which does NOT trigger actionObjectCombinationUpdateAfter. We rebuild
* the Combination object and forward it to the standard combination commit.
*
* @param array $params
*
* @return bool
*/
public function hookActionProductAttributeUpdate(array $params): bool
{
$idProductAttribute = isset($params['id_product_attribute'])
? (int) $params['id_product_attribute']
: 0;
if ($idProductAttribute <= 0) {
return true;
}
$combination = new Combination($idProductAttribute);
if (!\Validate::isLoadedObject($combination) || empty($combination->id_product)) {
return true;
}

return $this->hookactionCombination(
$combination,
SPL_A_UPDATE,
$this->l('Product Variant Updated on Prestashop')
);
}

/**
* This hook is called after a customer effectively places their order
*
Expand Down