Local dependencies and symlinks on Windows CI#688
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d09f04e2a9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # via links that can trigger EPERM on stat/access. | ||
| git config --global core.symlinks false | ||
|
|
||
| - uses: actions/checkout@v6 |
There was a problem hiding this comment.
In this Windows workflow, deleting the old core.symlinks false step still leaves actions/checkout dependent on the runner's Git-for-Windows default. Git documents that when core.symlinks is false, symlinks are checked out as small plain files, and Git for Windows can default that way on Windows environments; in that case this job still checks out the repo's tracked symlinks as text files rather than links, so the intended Windows symlink restoration is unreliable. Set git config --global core.symlinks true before checkout (or otherwise verify/reset the checkout) so the workflow actually exercises symlinks.
Useful? React with 👍 / 👎.
2 participants
This PR:
build-on-window.ymlworkflow so that Window builds at CI can enjoy symlinks back.