Skip to content

Fix bugs identified by user#224

Merged
RichardWaiteSTFC merged 1 commit into
masterfrom
balzbugs
Aug 5, 2025
Merged

Fix bugs identified by user#224
RichardWaiteSTFC merged 1 commit into
masterfrom
balzbugs

Conversation

@mducle

@mducle mducle commented Aug 5, 2025

Copy link
Copy Markdown
Member

C. Balz contacted me with some bugs - specifically relating to tutorials 12 and 35:

  • The syntax for disp2sqw_eval in Horace has changed and needs a flag '-all' at the end to compute the intensities, so we need to change the example in tutorial 12.
  • In tutorial 35, a long-known bug is that the experiment points shift if you resize the figure because they are actually 'circles' plotted on the canvas coordinates rather than the data coordinates. There are two work arounds which should be documented. - Fixed on webpage already
  • Finally, also related to tutorial 35 but not in the tutorial itself - sw_plotspec has the option to overplot data (like fitspec does) but it assumes that the column names are En#, I#, and s# whereas fitspec ignores the names and just uses the column ordering - but the example file LuVO3_fitted_modes.txt calls the final column sigma# rather than s# so sw_plotspec fails when given it as input.

@github-actions

github-actions Bot commented Aug 5, 2025

Copy link
Copy Markdown

Test Results

    4 files  ±0    124 suites  ±0   5m 26s ⏱️ +27s
  832 tests ±0    814 ✅ ±0  18 💤 ±0  0 ❌ ±0 
2 328 runs  ±0  2 292 ✅ ±0  36 💤 ±0  0 ❌ ±0 

Results for commit 84529bc. ± Comparison against base commit eacac5a.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.
sw_tests.unit_tests.unittest_ndbase_optimisers ‑ test_optimise_rosen_parameter_fixed_minimum_not_accessible_with(optimiser=@ndbase.lm4)
sw_tests.unit_tests.unittest_ndbase_optimisers ‑ test_optimise_rosen_parameter_fixed_minimum_not_accessible_with(optimiser=@ndbase.simplex)
sw_tests.unit_tests.unittest_ndbase_optimisers ‑ test_optimise_rosen_parameter_fixed_minimum_not_accessible_with_vary_arg(optimiser=@ndbase.lm4)
sw_tests.unit_tests.unittest_ndbase_optimisers ‑ test_optimise_rosen_parameter_fixed_minimum_not_accessible_with_vary_arg(optimiser=@ndbase.simplex)

@mducle
mducle requested a review from RichardWaiteSTFC August 5, 2025 13:37
@mducle mducle added the bug Something isn't working label Aug 5, 2025

@RichardWaiteSTFC RichardWaiteSTFC left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks!

I did have a quick test of tutorial 35 with the file attached in this PR - fitspec produced this
image
which agrees with
https://spinw.org/tutorials/35tutorial

@RichardWaiteSTFC
RichardWaiteSTFC merged commit ba7a369 into master Aug 5, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants