MMA-11008. fix extended auth patch#81
Draft
bitsikas wants to merge 1 commit into
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent crashes during rejected SMTP AUTH attempts by ensuring smtp_resp/errmsg are populated on all exit paths in smtp_in_auth() (reapplying behavior from prior patch work).
Changes:
- Populate
smtp_resp/errmsg(andauthenticated_fail_id) in additional AUTH failure paths to avoid NULL/uninitialized dereferences. - Reorder when
acl_smtp_auth_acceptis evaluated relative to setting the success response/state. - Move FAIL-path response initialization earlier (before
acl_smtp_auth_fail) to ensure response strings are always set.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why we need this
On rejected authentication attempts we don't always fill out the smtp_resp/errmsg before exiting causing segfaults.
Ticket
MMA-11008
How we fix this.
Reapply the changes from the previous patches #46