Skip to content
This repository was archived by the owner on Jun 28, 2026. It is now read-only.

Change AppData Path#5

Open
ShepardToTheStars wants to merge 1 commit into
Space-Wizards-Federation:masterfrom
ShepardToTheStars:path
Open

Change AppData Path#5
ShepardToTheStars wants to merge 1 commit into
Space-Wizards-Federation:masterfrom
ShepardToTheStars:path

Conversation

@ShepardToTheStars

Copy link
Copy Markdown

This launcher should not use the same sqlite databases (e.g. settings.db) as the launcher this was forked from.

@0x6273

0x6273 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Hm, it should probably migrate your settings/favorites then at least. Would be annoying for users to lose that.

@Princess-Cheeseballs Princess-Cheeseballs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Edit) Actually, instead of doing this it would be better to give the launcher the ability to set a custom directory. I can do that in a separate PR with my IDE if you don't get to it first.

@ShepardToTheStars

Copy link
Copy Markdown
Author

(Edit) Actually, instead of doing this it would be better to give the launcher the ability to set a custom directory. I can do that in a separate PR with my IDE if you don't get to it first.

We could. One of the issues with allowing that is we'd have to handle if the user can even write to that directory in the first place, since currently the data sits in a directory that's always accessible and write-able to the current user (it being in %APPDATA% or in the user's home directory on macOS/Linux).

@ShepardToTheStars

Copy link
Copy Markdown
Author

It's also a bit of a chicken and the egg problem, since this is only launcher data, not game/client data. So, if we're setting the launcher config path, we'd need to store it somewhere static, so when the application boots up, it knows that the user overrode the launcher data path and where to find that path. So, it couldn't live with the other settings.

@BarryNorfolk

BarryNorfolk commented Jun 16, 2026

Copy link
Copy Markdown

I believe that it'd save a lot of headache later on to be authoritative with where we put stuff so that we can be absolutely sure that people don't make silly mistakes or have really odd decisions about where they put folder structures.
If there are options for deleting logs/bundles/etc, then that needs to also factor in just in case someone decides to put their folder in a top level directory and we just rm -rf *.* everything in a directory.

Is on them for making silly mistakes, I'm just wary of adding "Space Station 14" branding to the footgun they've just shot themselves with.

@ShepardToTheStars

Copy link
Copy Markdown
Author

Just FYI, as long as you use the same sqlite database, you won't be in full control of the schema, which means that certain parties could break your launcher by doing migrations that screw up the tables.

Which is why I PR'd this in the first place.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants