Auth Server Hotswapping#3
Conversation
|
I shall hopefully be less busy tomorrow and will try to review then. |
Princess-Cheeseballs
left a comment
There was a problem hiding this comment.
Before I review tomorrow, changing auth servers should be prompted with a really big "ARE YOU SURE???" Since it can be a pretty massive security concern. Also, funky auth is supposed to be temporary so we'll probably not want the button to switch the FunkyAuth in the official launcher.
I'll probably have other things to poke tomorrow.
Funky Auth one exists for servers still using it, I have no idea if everyone will swap by tomorrow. Remove it in a future update |
I'll just code in some features when I am on my computer and have access to my IDE, specifically for verifying the auth server is valid among other things. |
|
Not sure about having "Current auth server:" on the login screen. Most people using the launcher aren't gonna know what an "auth server" even is, so I think it could be worded better and should probably only display the hostname instead of the full auth url. How about something like "Log in (via auth.playss14.com)" at the top instead? |
there is no validation for auth because there's no clean way to do it. it'll add a / if they forget it but that's it