Skip to content
This repository was archived by the owner on Jun 28, 2026. It is now read-only.

Auth Server Hotswapping#3

Open
sleepyyapril wants to merge 4 commits into
Space-Wizards-Federation:masterfrom
sleepyyapril:auth-swap
Open

Auth Server Hotswapping#3
sleepyyapril wants to merge 4 commits into
Space-Wizards-Federation:masterfrom
sleepyyapril:auth-swap

Conversation

@sleepyyapril

Copy link
Copy Markdown
Contributor
image image

there is no validation for auth because there's no clean way to do it. it'll add a / if they forget it but that's it

@Princess-Cheeseballs Princess-Cheeseballs self-assigned this Jun 15, 2026
@Princess-Cheeseballs

Copy link
Copy Markdown
Member

I shall hopefully be less busy tomorrow and will try to review then.

@Princess-Cheeseballs Princess-Cheeseballs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before I review tomorrow, changing auth servers should be prompted with a really big "ARE YOU SURE???" Since it can be a pretty massive security concern. Also, funky auth is supposed to be temporary so we'll probably not want the button to switch the FunkyAuth in the official launcher.

I'll probably have other things to poke tomorrow.

@sleepyyapril

Copy link
Copy Markdown
Contributor Author

Before I review tomorrow, changing auth servers should be prompted with a really big "ARE YOU SURE???" Since it can be a pretty massive security concern. Also, funky auth is supposed to be temporary so we'll probably not want the button to switch the FunkyAuth in the official launcher.

I'll probably have other things to poke tomorrow.

Funky Auth one exists for servers still using it, I have no idea if everyone will swap by tomorrow. Remove it in a future update

@Princess-Cheeseballs

Copy link
Copy Markdown
Member

Funky Auth one exists for servers still using it, I have no idea if everyone will swap by tomorrow. Remove it in a future update

I'll just code in some features when I am on my computer and have access to my IDE, specifically for verifying the auth server is valid among other things.

@0x6273

0x6273 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Not sure about having "Current auth server:" on the login screen. Most people using the launcher aren't gonna know what an "auth server" even is, so I think it could be worded better and should probably only display the hostname instead of the full auth url.

How about something like "Log in (via auth.playss14.com)" at the top instead?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants