Hardpoint system port#284
Open
nabegator220 wants to merge 12 commits into
Open
Conversation
github-actions
Bot
added
S: Untriaged
Changes: Sprites
size/M
KS: Design Doc present
S: Needs Review
and removed
S: Untriaged
labels
Contributor
|
RSI Diff Bot; head commit 7234855 merging into dbc17d7 Resources/Textures/_Crescent/Structures/hardpoints.rsi
Resources/Textures/_KS14/Shipmode/Structures/Shipguns/debug.rsi
|
Collaborator
|
I won't permit this level of code quality in the codebase never port from hullrot again i will edit the pr to fix this tomorrow while that happens change anything you want accordingly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Ports hardpoints (bare minimum functionality only) from Hullrot
Originally intended to port more but it is very deeply intertwined with datalink and etc. which means that 87 has to lay down at least some groundwork.
I will hopefully be able to port hullrot/mono (whichever we go with) ship projectile optimisations eventually to complement this.
Why
Hardpoints are necessary for the design of the shipfork.
Requirements
Changelog
🆑