fix: v0.5.38 — realpath buffer overflow in cmd_init on ubuntu-22.04#58
Merged
Conversation
Signed-off-by: SoundMatt <SoundMatt@users.noreply.github.com> Signed-off-by: Matt Jones <47545907+SoundMatt@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Without #define _GNU_SOURCE, realpath() is not declared from <stdlib.h> on strict POSIX/C99 builds. clang-15 failed with an undeclared-function error; gcc compiled with an implicit int-returning declaration which truncates the 64-bit pointer return value, causing free() to segfault. All other cmd/*.c files already carry the guard — align cmd_init.c. Signed-off-by: SoundMatt <SoundMatt@users.noreply.github.com> Signed-off-by: Matt Jones <47545907+SoundMatt@users.noreply.github.com>
| const char *slash = strrchr(abs, '/'); | ||
| strncpy(dir_basename, slash ? slash + 1 : abs, sizeof(dir_basename) - 1); | ||
| project = dir_basename; | ||
| free(resolved); |
| const char *slash = strrchr(abs, '/'); | ||
| strncpy(dir_basename, slash ? slash + 1 : abs, sizeof(dir_basename) - 1); | ||
| project = dir_basename; | ||
| free(resolved); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cmd_init.ccalledrealpath(dir, resolved)with a 512-byte stack buffer; glibc's__realpath_chk(enabled by_FORTIFY_SOURCE=2at-O2on ubuntu-22.04) requires the destination to be at leastPATH_MAX(4096 bytes), triggering*** buffer overflow detected ***: terminatedrealpath(dir, NULL)+free(), the same pattern already used incmd_check.c,cmd_report.c, andcmd_trace.cTest plan