fix: v0.5.37 — engine cleanup in cmd_qualify, CodeQL comment fix#57
Merged
Conversation
Add cfusa_engine_reset() at the end of cmd_qualify() to clear stale global rule-table state after the qualification exercise suite. Without this, helper functions (qt_run_safety_rules etc.) leave the engine pointing at freed stack memory, which glibc malloc detects as heap corruption (SIGABRT) at the next allocation inside test_cli_commands on ubuntu-22.04. Also replace the inline JSON format example in the parse_mcdc_json() block comment with prose, eliminating the CodeQL "Commented-out code" false-positive alert. Signed-off-by: SoundMatt <SoundMatt@users.noreply.github.com> Signed-off-by: Matt Jones <47545907+SoundMatt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cfusa_engine_reset()at the end ofcmd_qualify()to clear the global rule table after the qualification exercise suite. Without this, helper functions (qt_run_safety_rules,qt_run_cyber_rules, etc.) leave the engine pointing at freed stack-frame memory. On Linux, glibc malloc detects this heap corruption at the next allocation — insidetest_cli_commands— causing aSIGABRT("Subprocess aborted") on ubuntu-22.04 CI.parse_mcdc_json()block comment with prose, eliminating the CodeQL CWE "Commented-out code" false-positive alert.Test plan