Skip to content

fix(checkout): improve StepProgress layout on narrow mobile screens (#196) #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jeffrey-graham wants to merge 1 commit into from
Closed

fix(checkout): improve StepProgress layout on narrow mobile screens (#196) #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions src/components/checkout/StepProgress.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ interface StepProgressProps {

export function StepProgress({ currentStep, onStepClick, className }: StepProgressProps) {
return (
<nav aria-label="Checkout progress" className={cn('w-full', className)}>
<ol className="flex items-center justify-center gap-0">
<nav aria-label="Checkout progress" className={cn('w-full max-w-full overflow-hidden', className)}>
<ol className="flex w-full min-w-0 items-center justify-between gap-0">
{CHECKOUT_STEPS.map((step, index) => {
// Derived purely from currentStep so going back always resets later
// steps — there is no separate "completed" state that could go stale.
Expand All @@ -37,7 +37,7 @@ export function StepProgress({ currentStep, onStepClick, className }: StepProgre
const indicator = (
<span
className={cn(
'flex h-9 w-9 items-center justify-center rounded-full text-sm font-semibold transition-all duration-300',
'flex h-7 w-7 sm:h-9 sm:w-9 shrink-0 items-center justify-center rounded-full text-xs sm:text-sm font-semibold transition-all duration-300',
isCompleted &&
'bg-leaf-600 text-white shadow-md shadow-leaf-600/20',
isCurrent &&
Expand All @@ -47,7 +47,7 @@ export function StepProgress({ currentStep, onStepClick, className }: StepProgre
aria-current={isCurrent ? 'step' : undefined}
>
{isCompleted ? (
<svg className="h-5 w-5" fill="none" viewBox="0 0 24 24" stroke="currentColor" strokeWidth={2.5}>
<svg className="h-4 w-4 sm:h-5 sm:w-5" fill="none" viewBox="0 0 24 24" stroke="currentColor" strokeWidth={2.5}>
<path strokeLinecap="round" strokeLinejoin="round" d="M4.5 12.75l6 6 9-13.5" />
</svg>
) : (
Expand All @@ -57,9 +57,9 @@ export function StepProgress({ currentStep, onStepClick, className }: StepProgre
);

return (
<li key={step.step} className="flex items-center flex-1">
<li key={step.step} className="flex min-w-0 items-center flex-1 last:flex-none">
{/* Step indicator — clickable when completed and onStepClick is provided */}
<div className="flex flex-col items-center">
<div className="flex min-w-0 flex-col items-center text-center">
{isCompleted && onStepClick ? (
<button
type="button"
Expand All @@ -73,8 +73,9 @@ export function StepProgress({ currentStep, onStepClick, className }: StepProgre
indicator
)}
<span
data-testid={`checkout-step-label-${step.step}`}
className={cn(
'mt-1.5 text-[11px] font-medium uppercase tracking-[0.08em] transition-colors duration-300',
'mt-1 sm:mt-1.5 max-w-[4.75rem] sm:max-w-none truncate text-[9px] sm:text-[11px] font-medium uppercase tracking-tight sm:tracking-[0.08em] transition-colors duration-300',
isCompleted && 'text-leaf-700',
isCurrent && 'text-sorobanlard-primary font-semibold',
isFuture && 'text-ink-400',
Expand All @@ -86,7 +87,7 @@ export function StepProgress({ currentStep, onStepClick, className }: StepProgre

{/* Connector line */}
{index < CHECKOUT_STEPS.length - 1 && (
<div className="mx-3 flex-1">
<div className="mx-1.5 sm:mx-3 flex-1 min-w-[0.75rem]">
<div
className={cn(
'h-0.5 rounded-full transition-all duration-500',
Expand Down
11 changes: 11 additions & 0 deletions src/components/checkout/__tests__/StepProgress.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,4 +64,15 @@ describe('StepProgress', () => {
// Step 3 should now show its number, not a checkmark
expect(screen.getByText('3')).toBeInTheDocument();
});

it('applies compact responsive sizing and label truncation on narrow viewports (#196)', () => {
render(<StepProgress currentStep={1} />);
const nav = screen.getByRole('navigation', { name: /Checkout progress/i });
expect(nav.className).toContain('overflow-hidden');

const label1 = screen.getByTestId('checkout-step-label-1');
expect(label1.className).toContain('truncate');
expect(label1.className).toContain('text-[9px]');
expect(label1.className).toContain('sm:text-[11px]');
});
});