Repository navigation
fix(checks): avoid false positives for storage writes and admin guards - #941
Open
jiangyuer018 wants to merge 1 commit into
Open
jiangyuer018 wants to merge 1 commit into
jiangyuer018 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the fixes for #510 and #511.
missing-nonce, so localVec::pushandpush_backare not treated as persistent state writes.unprotected-adminconditional exemptions to reference tracked storage/address values and to actually diverge; no-opifstatements remain findings.missing-noncedocumentation with the implementation.This restores the divergence guard that was lost when the later #697 work was merged into
main.Validation:
git diff --checkpasses. Local Rust tests reach compilation but cannot link on this Windows host becauselink.exeis unavailable; remote CI is required for final build validation.