Repository navigation
config: add extends key for config inheritance - #939
Open
Paranoa-dev wants to merge 1 commit into
Open
Paranoa-dev wants to merge 1 commit into
Paranoa-dev wants to merge 1 commit into
Conversation
Addresses issue SorobanGuard#910 by adding an key to soroban-guard.toml that allows inheriting from a base configuration file. Changes: - Added field to GuardConfig - Modified load_from_path to load base config and merge with child - Added merge_scan_config and merge_checks_config helpers - Merging strategy: child values override base, arrays are combined (deduplicated) Added tests: - extends_loads_base_config_and_merges: verifies merge behavior - extends_with_relative_path: verifies relative path resolution - extends_nonexistent_file_returns_error: error handling - load_from_path_handles_extends: explicit path loading Example usage: Closes SorobanGuard#910
|
@Paranoa-dev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue #910 by adding an
extendskey tosoroban-guard.tomlthat allows inheriting from a base configuration file.Changes
extends: Option<String>field toGuardConfigincrates/cli/src/config.rsload_from_pathto load base config and merge with child configmerge_scan_configandmerge_checks_confighelper functionsExample Usage
Testing
Added comprehensive tests in
config.rs:extends_loads_base_config_and_merges: verifies merge behavior for scan and checksextends_with_relative_path: verifies relative path resolutionextends_nonexistent_file_returns_error: error handling for missing baseload_from_path_handles_extends: explicit path loading with extendsCloses #910