Repository navigation
Move the XDR generator to activesupport 8.1.4.1 - #207
Merged
Merged
Conversation
Before this change, the XDR generator tool locked activesupport 6.1.7.10 through the xdrgen fork, and GHSA-8474-xrp6-wh69 is fixed only in 8.0.5.2 and 8.1.4.1. The advisory affected the build tool only: the gem is not part of the SDK, and xdrgen does not call the affected method. This change: - Pins the xdrgen fork at the commit that requires activesupport 8.1.4.1 or later and Ruby 3.2 or later. - Updates the lock: activesupport 8.1.4.1 with the gems it needs. - States Ruby 3.2 or later in the generator documentation. The generator tests pass and the regenerated XDR code is identical to the committed code.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
=========================================
Coverage 93.51% 93.51%
Complexity 21684 21684
=========================================
Files 1007 1007
Lines 52601 52601
=========================================
Hits 49189 49189
Misses 3412 3412 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, the XDR generator tool locked activesupport 6.1.7.10 through the xdrgen fork, and GHSA-8474-xrp6-wh69 is fixed only in 8.0.5.2 and 8.1.4.1. The advisory affected the build tool only: the gem is not part of the SDK, and xdrgen does not call the affected method.
This change:
The generator tests pass and the regenerated XDR code is identical to the committed code.