Skip to content

Re-simulate the custom account test in enforcing auth mode #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christian-rogobete merged 1 commit into from
Nov 11, 2026
Merged

Re-simulate the custom account test in enforcing auth mode #206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 34 additions & 45 deletions Soneso/StellarSDKTests/Integration/SorobanCustomAccountTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,11 @@
use Soneso\StellarSDK\UploadContractWasmHostFunction;
use Soneso\StellarSDKTests\PrintLogger;
use Soneso\StellarSDKTests\TestUtils;
use Soneso\StellarSDK\Xdr\XdrContractDataDurability;
use Soneso\StellarSDK\Xdr\XdrInt128Parts;
use Soneso\StellarSDK\Xdr\XdrLedgerEntryType;
use Soneso\StellarSDK\Xdr\XdrLedgerFootprint;
use Soneso\StellarSDK\Xdr\XdrLedgerKey;
use Soneso\StellarSDK\Xdr\XdrLedgerKeyContractCode;
use Soneso\StellarSDK\Xdr\XdrLedgerKeyContractData;
use Soneso\StellarSDK\Xdr\XdrSCVal;
use Soneso\StellarSDK\Xdr\XdrSorobanResources;
use Soneso\StellarSDK\Xdr\XdrSorobanTransactionData;
Expand Down Expand Up @@ -201,19 +199,10 @@ private function addLimit(SorobanServer $server, Keypair $submitterKp, String $c
$transaction = (new TransactionBuilder($account))
->addOperation($op)->build();

// The recording-mode simulation returns the auth entries without running the
// account contract's __check_auth.
$request = new SimulateTransactionRequest($transaction);
$simulateResponse = $server->simulateTransaction($request);
$transactionData = $simulateResponse->getTransactionData();

// add some resources because preflight can not take __check_auth into account
$transactionData->resources->diskReadBytes *= 3;
$transactionData->resources->instructions *= 4;
$transactionData->resourceFee += 1500800;
$simulateResponse->minResourceFee += 1500800;

// set the transaction data + fee and sign
$transaction->setSorobanTransactionData($transactionData);
$transaction->addResourceFee($simulateResponse->minResourceFee);

$auth = $simulateResponse->getSorobanAuth();
$this->assertNotNull($auth);
Expand All @@ -234,6 +223,17 @@ private function addLimit(SorobanServer $server, Keypair $submitterKp, String $c
}
}
$transaction->setSorobanAuth($auth);

// The enforcing re-simulation of the signed transaction runs __check_auth and returns
// the footprint, resources and fee the submitted transaction needs.
$enforceRequest = new SimulateTransactionRequest(transaction: $transaction, authMode: 'enforce');
$enforceResponse = $server->simulateTransaction($enforceRequest);
$this->assertNull($enforceResponse->error);
$this->assertNull($enforceResponse->resultError);
$this->assertNotNull($enforceResponse->getTransactionData());
$this->assertNotNull($enforceResponse->minResourceFee);
$transaction->setSorobanTransactionData($enforceResponse->getTransactionData());
$transaction->addResourceFee($enforceResponse->minResourceFee);
$transaction->sign($submitterKp, $this->network);

// send the transaction
Expand Down Expand Up @@ -276,32 +276,10 @@ private function transfer(bool $expectSuccess, SorobanServer $server, Keypair $s
$transaction = (new TransactionBuilder($account))
->addOperation($op)->build();

// The recording-mode simulation returns the auth entries without running the
// account contract's __check_auth.
$request = new SimulateTransactionRequest($transaction);
$simulateResponse = $server->simulateTransaction($request);
$transactionData = $simulateResponse->getTransactionData();

// add some resources because preflight can not take __check_auth into account
$transactionData->resources->diskReadBytes *= 3;
$transactionData->resources->instructions *= 4;
$transactionData->resourceFee += 1500800;
$simulateResponse->minResourceFee += 1500800;

// we need to extend the footprint, so that __check_auth can read from storage
$readOwnersKey = new XdrLedgerKey(XdrLedgerEntryType::CONTRACT_DATA());
$addr = Address::fromContractId($accContractId)->toXdr();
$readOwnersKey->contractData = new XdrLedgerKeyContractData($addr, XdrSCVal::forSymbol("Owners"),
XdrContractDataDurability::PERSISTENT());

$readLimitKey = new XdrLedgerKey(XdrLedgerEntryType::CONTRACT_DATA());
$readLimitKey->contractData = new XdrLedgerKeyContractData($addr, XdrSCVal::forSymbol("SpendMax"),
XdrContractDataDurability::PERSISTENT());

array_push($transactionData->resources->footprint->readOnly , $readOwnersKey);
array_push($transactionData->resources->footprint->readOnly , $readLimitKey);

// set the transaction data + fee and sign
$transaction->setSorobanTransactionData($transactionData);
$transaction->addResourceFee($simulateResponse->minResourceFee);

$auth = $simulateResponse->getSorobanAuth();
$this->assertNotNull($auth);
Expand All @@ -326,6 +304,24 @@ private function transfer(bool $expectSuccess, SorobanServer $server, Keypair $s
}
$transaction->setSorobanAuth($auth);

// The enforcing re-simulation of the signed transaction runs __check_auth and returns
// the footprint, resources and fee the submitted transaction needs.
$enforceRequest = new SimulateTransactionRequest(transaction: $transaction, authMode: 'enforce');
$enforceResponse = $server->simulateTransaction($enforceRequest);
$this->assertNull($enforceResponse->error);
if (!$expectSuccess) {
// __check_auth rejects a transfer above the spend limit without every owner's
// signature with the account contract's error NOT_ENOUGH_SIGNERS (3).
$this->assertNotNull($enforceResponse->resultError);
$this->assertStringStartsWith('HostError: Error(Auth, InvalidAction)', $enforceResponse->resultError);
$this->assertStringContainsString('Error(Contract, #3)', $enforceResponse->resultError);
return;
}
$this->assertNull($enforceResponse->resultError);
$this->assertNotNull($enforceResponse->getTransactionData());
$this->assertNotNull($enforceResponse->minResourceFee);
$transaction->setSorobanTransactionData($enforceResponse->getTransactionData());
$transaction->addResourceFee($enforceResponse->minResourceFee);
$transaction->sign($submitterKp, $this->network);

// send the transaction
Expand All @@ -334,14 +330,7 @@ private function transfer(bool $expectSuccess, SorobanServer $server, Keypair $s

// poll until status is success or error
$statusResponse = $this->pollStatus($server, $sendResponse->hash);
/*if ($statusResponse->status == GetTransactionResponse::STATUS_FAILED) {
print("ERR RESULT XDR: " . $statusResponse->resultXdr . PHP_EOL);
}*/
if ($expectSuccess) {
$this->assertEquals(GetTransactionResponse::STATUS_SUCCESS, $statusResponse->status);
} else {
$this->assertEquals(GetTransactionResponse::STATUS_FAILED, $statusResponse->status);
}
$this->assertEquals(GetTransactionResponse::STATUS_SUCCESS, $statusResponse->status);
}

private function deployContract(SorobanServer $server, String $pathToCode, KeyPair $submitterKp, ?array $constructorArgs = null) : array {
Expand Down
Loading