Repository navigation
Document the Stellar Asset Contract client - #205
Merged
Merged
Conversation
Add a chapter on SACClient to the Soroban guide and a SACClient passage with three common mistakes to the skill's contract reference.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-docs #205 +/- ##
===============================================
Coverage 93.41% 93.41%
Complexity 21578 21578
===============================================
Files 1006 1006
Lines 52310 52310
===============================================
Hits 48866 48866
Misses 3444 3444 🚀 New features to boost your workflow:
|
Before this change, the Stellar Asset Contract chapter showed a contract sender example that submitted with a placeholder signature, and advised higher resources for the wallet's check. This change describes the steps in prose: complete the authorization entry, re-simulate in enforcing mode, apply the returned transaction data and set the fee. It also states the largest amount toBaseUnits() accepts.
Member
|
Tank you @ngybnc! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a chapter on SACClient to the Soroban guide and a SACClient passage with three common mistakes to the skill's contract reference. The client is added in #204.