SONARAZDO-589 Fix test using promise-returning assertion without awaiting

[antoine-vinot-sonarsource]

Fixes issues appearing after new rules were added to the Typescript QP.

---

Summary by Gitar

• Test fixes:
  • Added async/await to tests in api-test.ts to properly handle promise-returning assertions
  • Corrected expect(...).rejects.toThrow() calls that were previously missing the required await

_{This will update automatically on new commits.}

[hashicorp-vault-sonar-prod]

SONARAZDO-589

[gitar-bot]

Code Review ✅ Approved

Added missing await statements to promise-returning assertions in api-test.ts, ensuring proper test execution and validation. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}

[sonarqube-next]

Quality Gate passed for 'Azure DevOps extension for SonarQube Server'

Issues
0 New issues
5 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

[sonarqube-next]

Quality Gate passed for 'Azure DevOps extension for SonarQube Cloud'

Issues
0 New issues
5 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

[zglicz]

The change makes sense: for Jest .rejects, the assertion promise should be awaited, while the promise under test should be passed directly to expect(...).

One follow-up worth considering: the same unawaited .rejects pattern is still present in the sibling common variants:

• src/common/sonarqube-v7/helpers/__tests__/api-test.ts:125, :133, :185, :198, :205
• src/common/sonarcloud-v3/helpers/__tests__/api-test.ts:125, :133, :185, :198, :205

Those look like active test packages under the root npm test wiring, so it would be good to apply the same cleanup there too, either in this PR or a follow-up.

[antoine-vinot-sonarsource]

The change makes sense: for Jest .rejects, the assertion promise should be awaited, while the promise under test should be passed directly to expect(...).

One follow-up worth considering: the same unawaited .rejects pattern is still present in the sibling common variants:

• src/common/sonarqube-v7/helpers/__tests__/api-test.ts:125, :133, :185, :198, :205
• src/common/sonarcloud-v3/helpers/__tests__/api-test.ts:125, :133, :185, :198, :205

Those look like active test packages under the root npm test wiring, so it would be good to apply the same cleanup there too, either in this PR or a follow-up.

@zglicz Thank you for the review!
v7 and v3 are deprecated versions of our tasks. I made a deliberate choice to not touch them and accepted the related issues.