SC-49820 Severity metrics decoration

[OrlovAlexander85]

Adding formatters for new Severity Metrics Conditions

[hashicorp-vault-sonar-prod]

SC-49820

[stanislavhh]

Overall looks good, small suggestion, and given that we introduced new measure type, it will be a good idea to verify that measure is rendered in html as expected (comparator, measure name)

[sonarqube-next]

Quality Gate passed for 'Azure DevOps extension for SonarQube Cloud'

Issues
0 New issues
3 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
89.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[stanislavhh]

LGTM

[antoine-vinot-sonarsource]

@OrlovAlexander85 Quick heads-up. I'm trying to validate the changes from a functional point of view, because our ITs don't handle the fail QG scenario I believe. However I faced some issues (not related to your changes) when trying it on a Dev environment.
Please bear with me a little bit more 🙏

[antoine-vinot-sonarsource]

I tried it out and the change works for the formatted evaluation at the start of the line. However, the required threshold is not properly formatted because it shows "one less" than the value associated to the given severity.
See my screenshot below: I set up the QG to INFO level, hence it show required <= 4 and not required < INFO (Or whatever we want there)

[OrlovAlexander85]

@antoine-vinot-sonarsource Thanks a lot for doing functional validation.
I will add a proper mapping to a condition as well

[antoine-vinot-sonarsource]

LGTM!

@OrlovAlexander85 The pipeline failed because of some timeout when publishing the test extension. It's a known thing for which I did not find a solution yet sadly. You might need to retrigger a new pipeline, as rerunning the failed one won't work I think.

[sonarqube-next]

Quality Gate passed for 'Azure DevOps extension for SonarQube Server'

Issues
0 New issues
1 Fixed issue
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
91.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[sonarqube-next]

Quality Gate passed for 'Azure DevOps extension for SonarQube Cloud'

Issues
0 New issues
1 Fixed issue
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
91.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[OrlovAlexander85]

Hey @antoine-vinot-sonarsource , once again thanks a lot for validation. I rerun the pipeline and all checks are green and PR is ready to be merged.
Can you please merge it, as I do not have required permissions on this repo.

[gitar-bot]

Code Review ✅ Approved 1 resolved / 1 findings

Implements severity metrics decoration for project analysis, though the removal of existing tests leaves this feature currently untested.

✅ 1 resolved

✅ Quality: Severity formatter tests and snapshots removed, leaving feature untested

📄 src/common/latest/sonarqube/tests/HtmlAnalysisReport-test.ts 📄 src/common/sonarcloud-v3/sonarqube/tests/HtmlAnalysisReport-test.ts 📄 src/common/sonarqube-v7/sonarqube/tests/HtmlAnalysisReport-test.ts 📄 src/common/latest/helpers/measures.ts:175-189
The most recent commit (Revert "SC-49820 PR review") removes the unit tests and snapshots that exercised the newly added severity-metrics decoration. Across all three modules it deletes the "should render full HTML for standard severity condition..." and "should render full HTML for MQR severity condition..." tests (56 lines each in HtmlAnalysisReport-test.ts) plus the associated 78-line .snap snapshot files. These were the only tests covering severityFormatter, severityMqrFormatter, and getEffectiveMetricType / the SEVERITY and SEVERITY_MQR formatter wiring in measures.ts.

The production code that maps severity values (5/10/15/20/25 → INFO/MINOR/.../BLOCKER and MQR labels) and resolves metric types still ships, but it now has no automated coverage, so regressions (e.g. an incorrect label-key mapping or a broken metricKey lookup) would go undetected. If the revert was intended only to drop the parseInt→Number refactor, the test/snapshot deletions appear to be unintended collateral. Restore the severity formatter tests and snapshots before merging.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}