fix(dashboard): preserve cancelled request count - #1766
Conversation
|
@codex review |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe dashboard metrics schema now accepts optional nullable ChangesDashboard cancelled-count preservation
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized dashboard schema fix preserves the backend-provided cancelled request count while remaining compatible with older servers; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Preserve the backend-provided
cancelledCountthrough the dashboard overview Zod boundary instead of silently stripping it. Keep the field nullable and optional for compatibility with older servers.Related to #1552. Frontend follow-up to #1696.
Type of change
fix:— bug fix (no behavior change beyond the bug)Changes
cancelledCountinDashboardMetricsSchemawith nonnegative integer semanticsDashboardOverviewSchema.parseboundarypreserve-dashboard-cancelled-countOpenSpec artifactsVerification
bun test src/features/dashboard/schemas.test.ts— 42 passedopenspec validate preserve-dashboard-cancelled-count --strict— passedmake test-postgrespassed 130 tests against isolated PostgreSQL 18git diff --check— passedOpenSpec
openspec/changes/preserve-dashboard-cancelled-count/Simplicity and UI evidence
No new configuration, navigation, dependency, or visible UI surface. Screenshots are not applicable because this is a typed consumer-contract fix only.
Summary by CodeRabbit
New Features
Tests
Documentation