fix(models): correct GPT-5.6 context windows - #1691
Conversation
|
Thanks — the value itself checks out: upstream corrected GPT-5.6 Sol/Terra/Luna to 272000 in codex-rs/models-manager/models.json starting at rust-v0.145.0 (372000 was only ever in rust-v0.144.1, which is what our catalog pinned). Three things before this can merge:
Also, in the test comments, prefer citing |
|
To use Codex here, create an environment for this repo. |
…6-context-windows # Conflicts: # tests/integration/test_v1_models.py # tests/unit/test_model_registry.py
|
Addressed the merge blockers.
Validated: focused GPT-5.6 bootstrap tests (2 passed), |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f43fefb80c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c04455d672
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Evidence
Authenticated live
/codex/modelscatalog fetches from three Plus accounts and one Pro account all reported272000forgpt-5.6-sol,gpt-5.6-terra, andgpt-5.6-luna. The local spike artifacts containing that evidence are intentionally untracked and are not part of this PR.Validation
uv run pytest tests/unit/test_model_registry.py::test_bootstrap_models_include_representative_upstream_metadatauv run pytest tests/integration/test_v1_models.py::test_backend_codex_models_uses_bootstrap_upstream_metadatauv run ruff check app/core/openai/model_registry.py tests/integration/test_v1_models.py tests/unit/test_model_registry.pyuv run ruff format --check app/core/openai/model_registry.py tests/integration/test_v1_models.py tests/unit/test_model_registry.py