Make Correct/Incorrect vote buttons restate the value they confirm - #12
Merged
Conversation
Beta feedback (issue #6): clicking generic "Correcte" on the dialect step didn't register as agreeing with a specific value, since the button looked like the same advance/agree affordance used everywhere else in the flow. Extend the fix beyond dialect to gender and transcription-edit, where the same ambiguity applies: - Dialect: "Sí, és {dialecte}" / "No, no és {dialecte}" - Gender: "Sí, és un home/una dona" / "No, és una dona/un home" (binary, so incorrect asserts the opposite directly) - Transcription (edit mode): "Desa la transcripció com a correcta" Button text now wraps and shrinks (text-sm, leading-tight) instead of forcing a single line, since dialect names like "Nord-occidental" no longer fit. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Member
Author
They're still linked from the PR description (pinned to commit 754500e), just not kept in the tree/history that reaches main. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
text-sm,leading-tight) instead of forcing one line — needed since dialect names like "Nord-occidental" don't fit on a single line at mobile widths.Screenshots
Verified at 375px width against real data in the dev DB (worst case: the longest dialect name, unvoted so it falls back to the raw detected value). Images are linked from the commit that added them rather than the repo tree — they were removed from the branch afterward to avoid committing screenshots to history.
Dialect — longest-name case, wraps to 3 lines but stays contained:
Gender — fits on one line:
Transcription, edit mode:
Test plan
tsc --noEmitpassesdocker compose up -d --buildwas run locally; not clicked through end-to-end by a human yet)🤖 Generated with Claude Code