Skip to content

Make Correct/Incorrect vote buttons restate the value they confirm - #12

Merged
ccoreilly merged 3 commits into
mainfrom
fix-vote-button-value-labels
Aug 2, 2026
Merged

Make Correct/Incorrect vote buttons restate the value they confirm#12
ccoreilly merged 3 commits into
mainfrom
fix-vote-button-value-labels

Conversation

@ccoreilly

@ccoreilly ccoreilly commented Aug 2, 2026

Copy link
Copy Markdown
Member

Summary

  • Closes Clarify dialect "Correcte" UX — unclear it means agreeing with shown value #6. Beta feedback: clicking the generic "Correcte" button on the dialect step didn't register as agreeing with the specific dialect shown — it looked like the same advance/agree affordance used on every step.
  • The fix goes beyond dialect: gender and transcription-edit had the same ambiguity, so all three now restate what's being confirmed:
    • Dialect: "Sí, és {dialecte}" / "No, no és {dialecte}"
    • Gender (binary, so "incorrect" asserts the opposite directly instead of just negating): "Sí, és un home" / "No, és una dona" (and vice versa)
    • Transcription, edit mode only: "Desa la transcripció com a correcta"
  • Button text now wraps and shrinks (text-sm, leading-tight) instead of forcing one line — needed since dialect names like "Nord-occidental" don't fit on a single line at mobile widths.

Screenshots

Verified at 375px width against real data in the dev DB (worst case: the longest dialect name, unvoted so it falls back to the raw detected value). Images are linked from the commit that added them rather than the repo tree — they were removed from the branch afterward to avoid committing screenshots to history.

Dialect — longest-name case, wraps to 3 lines but stays contained:

dialect

Gender — fits on one line:

gender

Transcription, edit mode:

transcription edit

Test plan

  • tsc --noEmit passes
  • Locale JSON valid (en/ca)
  • Manually driven with Playwright against the real dev backend/DB at 375px width — checked all three dimensions, including the longest dialect name ("Nord-occidental") to confirm buttons wrap instead of overflowing
  • Manual click-through in the running app (docker compose up -d --build was run locally; not clicked through end-to-end by a human yet)

🤖 Generated with Claude Code

ccoreilly and others added 2 commits August 2, 2026 08:30
Beta feedback (issue #6): clicking generic "Correcte" on the dialect
step didn't register as agreeing with a specific value, since the
button looked like the same advance/agree affordance used everywhere
else in the flow. Extend the fix beyond dialect to gender and
transcription-edit, where the same ambiguity applies:

- Dialect: "Sí, és {dialecte}" / "No, no és {dialecte}"
- Gender: "Sí, és un home/una dona" / "No, és una dona/un home"
  (binary, so incorrect asserts the opposite directly)
- Transcription (edit mode): "Desa la transcripció com a correcta"

Button text now wraps and shrinks (text-sm, leading-tight) instead of
forcing a single line, since dialect names like "Nord-occidental" no
longer fit.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@ccoreilly

Copy link
Copy Markdown
Member Author

@jordimas @jmontane que us sembla aquest canvi? Potser deixa més clar el que vol dir votar correcte/incorrecte?

They're still linked from the PR description (pinned to commit
754500e), just not kept in the tree/history that reaches main.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@jordimas

jordimas commented Aug 2, 2026

Copy link
Copy Markdown

@jordimas @jmontane que us sembla aquest canvi? Potser deixa més clar el que vol dir votar correcte/incorrecte?

Ho veig molt millor. Ara queda clar a que estàs dient que està correcte. Per mi és molt més clar.

@ccoreilly
ccoreilly merged commit 0d691f4 into main Aug 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify dialect "Correcte" UX — unclear it means agreeing with shown value

2 participants