ci: add Node CI workflow - #164
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
| Filename | Overview |
|---|---|
| .github/workflows/ci.yml | Adds appropriately scoped Node/Go CI coverage, with the remaining non-blocking concern that action dependencies are referenced through mutable major tags. |
Prompt To Fix All With AI
### Issue 1
.github/workflows/ci.yml:23
**Mutable Action References**
The new workflow references `actions/checkout`, `actions/setup-go`, and `actions/setup-node` through mutable `@v7` tags. If an upstream tag is moved or its publishing account is compromised, unreviewed code will execute in every CI run. Pinning each action to a full commit SHA would make the executed revisions immutable.
**How this was verified:** All three changed `uses` entries resolve through mutable major-version tags and execute on the runner before repository checks.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "ci: add Node CI workflow" | Re-trigger Greptile
Summary
Adds a standalone read-only Node CI workflow for ShellPort pull requests and main pushes.
What Changed
ci.ymlfor pull request, main push, and manual runs.go.modand Node.js 24 with npm caching.npm ci,npm run lint, andnpm test.Why
ShellPort's package scripts already define the frontend lint and combined frontend/Go test path. Running them in an independent CI gate makes those checks consistent for pull requests and main while provisioning the Go toolchain required by
npm test.Validation
npm cinpm run lint— passed with one existing unused-variable warning.npm test— 38 Vitest files / 237 tests passed; all Go race tests passed.prek run --files .github/workflows/ci.yml— passed, including YAML and actionlint.git diff --checkpassed.